Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENG-5224 ENG-5242 feat(graphql,1ui,template): graphql package update to new schema and modified codegen #997

Merged
merged 11 commits into from
Dec 27, 2024

Conversation

jonathanprozzi
Copy link
Member

Affected Packages

Apps

  • data populator
  • portal
  • template

Packages

  • 1ui
  • api
  • graphql
  • protocol
  • sdk

Tools

  • tools

Overview

  • Updates our GraphQL package to use the new schema and deployment and brings in the fragment and query changes from the feature branches.
  • Changes the codegen approach to not rely on environment variables at all so that the build process is more robust and flexible for people using in external apps. Uses the local schema first and then the remote as a fallback. This will be handled in a more thorough way in an upcoming PR.
  • Updates the local schema.graphql to match the remote one.
  • Updates 1ui and template to use fields from the updated schema.
  • Note: There is an unrelated typecheck issue in Portal related to the new Privy version that is causing the build to fail. We should handle that in another PR that is merged in prior to this one. I don't want to do that in this PR.

Screen Captures

If applicable, add screenshots or screen captures of your changes.

Declaration

  • I hereby declare that I have abided by the rules and regulations as outlined in the CONTRIBUTING.md

@jonathanprozzi jonathanprozzi changed the title ENG-5224,ENG-5242 feat(graphql,1ui,template): graphql package update to new schema and modified codegen ENG-5224 ENG-5242 feat(graphql,1ui,template): graphql package update to new schema and modified codegen Dec 24, 2024
@jonathanprozzi jonathanprozzi force-pushed the eng-5224-graphql-schema-package-updates branch from b13f2bc to 08d072b Compare December 24, 2024 16:05
@jonathanprozzi
Copy link
Member Author

Note: There is an unrelated typecheck issue in Portal related to the new Privy version that is causing the build to fail. We should handle that in another PR that is merged in prior to this one. I don't want to do that in this PR.

Mentioned this in the PR body but wanted to add a comment too

…n updating the schema -- re-runs codegen, and adds a local first approach with the remote schema fallback.
Copy link
Member

@0xjojikun 0xjojikun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@jonathanprozzi jonathanprozzi enabled auto-merge (squash) December 27, 2024 01:16
@jonathanprozzi jonathanprozzi merged commit 89a80e6 into main Dec 27, 2024
3 checks passed
@jonathanprozzi jonathanprozzi deleted the eng-5224-graphql-schema-package-updates branch December 27, 2024 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants