ENG-4592 feat(graphql,template): add environment handling graphql and example in template #969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… can support fully configurable apiUrl overrides similar to apollo and prisma -- bumps version and also exports API URLs as constants
…e overridable apiUrl
10 tasks
0xjojikun
reviewed
Dec 9, 2024
| fetcher: '../client#fetcher', | ||
| fetcher: { | ||
| func: '../client#fetcher', | ||
| isReactHook: false, |
There was a problem hiding this comment.
is this only for fetcher? with this option do we still generate hooks?
There was a problem hiding this comment.
It's just for the fetcher. I ran codegen a few times since and we still have hooks but going to double check
0xjojikun
approved these changes
Dec 9, 2024
jonathanprozzi
added a commit
that referenced
this pull request
Dec 9, 2024
- Brings in crucial parts of the most recent PRs into `main` so that we can continue working on migrating to the new schema/architecture on the `feature/graphql-migration` branch - This includes the logic in #969 -- we'll want to review that first so any changes can also be reflected in here. Including that logic will make working with the local API/schema more direct since we can configure the URL a bit easier. - I'm reasonably sure that I got everything. We'll have to deal with this again when we merge this branch into `main` but now that the GraphQL package is published #969 should be the last PR until we merge this feature branch in. If we change approaches we can modify the feature branch accordingly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Affected Packages
Apps
Packages
Tools
Overview
apiUrlfor the GraphQL package. AconfigureClientis now exported along with API URLs as constants. Consuming apps can optionally callconfigureClientat the highest level of their app (such asroot.tsxin Remix,layout.tsxin Next.js app router, or above the app configuration in an Express app).DEFAULT_API_URLin the package is currently set to dev for now.configureClient({ apiUrl: process.env.NODE_ENV === 'production' ? API_URL_PROD : API_URL_DEV, })which has been added to the template'sroot.tsxas an example.Screen Captures
If applicable, add screenshots or screen captures of your changes.
Declaration