Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENG-4730 fix(1ui): format large numbers in StakeButton #921

Conversation

Vitalsine85
Copy link
Member

Affected Packages

Apps

  • data populator
  • portal
  • template

Packages

  • 1ui
  • api
  • graphql
  • protocol
  • sdk

Tools

  • tools

Overview

Formats large numbers down to prevent issues with icon shrinking/overflow in StakeButtons. i.e. 2,330 -> 2.3k

Screen Captures

If applicable, add screenshots or screen captures of your changes.

Declaration

  • I hereby declare that I have abided by the rules and regulations as outlined in the CONTRIBUTING.md

Copy link

linear bot commented Nov 16, 2024

@github-actions github-actions bot added the fix Fix label Nov 16, 2024
Copy link
Member

@jonathanprozzi jonathanprozzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs quick update to the spec tests and should be good!

@Vitalsine85 Vitalsine85 enabled auto-merge (squash) November 16, 2024 14:36
@Vitalsine85 Vitalsine85 merged commit 4358cde into main Nov 16, 2024
3 checks passed
@Vitalsine85 Vitalsine85 deleted the vital/eng-4730-add-formatting-to-atomtriple-buttons-limiting-positions-to-3 branch November 16, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants