ENG-4712 fix(portal,1ui): responsiveness fixes #913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vitalsine85
force-pushed
the
vital/eng-4712-responsiveness-fixes
branch
from
158769a to
3d0d43c
Compare
jonathanprozzi
approved these changes
Nov 15, 2024
| @@ -48,6 +49,7 @@ export function ClaimsList({ | |||
| readOnly?: boolean | |||
| }) { | |||
| const setStakeModalActive = useSetAtom(stakeModalAtom) | |||
| const { isMobileView } = useSidebarLayoutContext() | |||
There was a problem hiding this comment.
I'm glad that we have this hook. I'm wondering if it makes sense to pull the isMobileView out at some point into a hook that's more specifically about mobile view, such as like useMobileView or something since I always forget where this is.
Mainly noting for our future selves
There was a problem hiding this comment.
Both this and container queries.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Affected Packages
Apps
Packages
Tools
Overview
Fixed some issues with responsiveness/mobile, primarily surround the new Claim/Identity/ActivityRow, ListCard, ListGrid, and FeaturedListsCarousel. There are some other tweaks here and there, but nothing notable.
Screen Captures
If applicable, add screenshots or screen captures of your changes.
Declaration