Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENG-4319 fix(portal): fix edit profile form submission #855

Merged
merged 2 commits into from
Sep 30, 2024

Conversation

Vitalsine85
Copy link
Member

Affected Packages

Apps

  • portal

Packages

  • 1ui
  • api
  • protocol
  • sdk

Tools

  • tools

Overview

Issue Addressed:
When users pressed the Enter key within a form field in the Edit Profile form, the application would display a black screen, and the form submission would fail to process.

Changes Made:

  • Updated the Submit Button:
    • Removed the existing onClick handler that wasn't correctly invoking the submission function if a user hit Enter.
    • Added type="submit" to the button to ensure it triggers the form submission when clicked or when Enter is pressed.

Outcome:
With these adjustments, the form now correctly handles submissions both by clicking the submit button and by pressing the Enter key, fixing the previous issue of the black screen and ensuring a smooth user experience.

Screen Captures

If applicable, add screenshots or screen captures of your changes.

Declaration

  • I hereby declare that I have abided by the rules and regulations as outlined in the CONTRIBUTING.md

Copy link

linear bot commented Sep 27, 2024

ENG-4319 [Portal] Can't update Profile

When I try to update my bio/description, it doesn't update.

When I push 'Update Profile', it says 'Updating Profile', then the modal closes, then the screen goes black. If I refresh the page, my profile has not updated.

@@ -433,11 +433,9 @@ export function EditProfileForm({
</div>
<Button
form={form.id}
type="submit"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@Vitalsine85 Vitalsine85 enabled auto-merge (squash) September 30, 2024 16:35
@Vitalsine85 Vitalsine85 merged commit 7fee61c into main Sep 30, 2024
3 checks passed
@Vitalsine85 Vitalsine85 deleted the vital/eng-4319-portal-cant-update-profile branch September 30, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants