Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENG-5279 feat(graphql,sdk): remove api dependencies from sdk and graphql #1009

Merged
merged 2 commits into from
Jan 2, 2025

Conversation

jonathanprozzi
Copy link
Member

@jonathanprozzi jonathanprozzi commented Dec 30, 2024

Affected Packages

Apps

  • data populator
  • portal
  • template

Packages

  • 1ui
  • api
  • graphql
  • protocol
  • sdk

Tools

  • tools

Overview

  • Removes the inclusion of the 0xintuition/api package as dependency in graphql and sdk packages
  • Ran a pnpm install afterward so the pnpm-lock.yaml change reflects this
  • This resolves installation issues for apps outside of the monorepo
  • Note: Leaving it in the template and data-populator for now because it's more integrated as part of certain flows. We can remove these gradually -- don't want to disrupt any working flows at the moment.

Screen Captures

If applicable, add screenshots or screen captures of your changes.

Declaration

  • I hereby declare that I have abided by the rules and regulations as outlined in the CONTRIBUTING.md

Copy link

linear bot commented Dec 30, 2024

@jonathanprozzi jonathanprozzi changed the title ENG-5279 feat(graphql,sdk) feat: remove api dependencies from sdk and graphql ENG-5279 feat(graphql,sdk): remove api dependencies from sdk and graphql Dec 30, 2024
@jonathanprozzi jonathanprozzi merged commit 3fe76f9 into main Jan 2, 2025
3 of 5 checks passed
@jonathanprozzi jonathanprozzi deleted the eng-5279-remove-api-dependencies branch January 2, 2025 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants