Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENG-5260 fix(portal): add arg to dockerfile #1004

Merged
merged 2 commits into from
Dec 27, 2024
Merged

ENG-5260 fix(portal): add arg to dockerfile #1004

merged 2 commits into from
Dec 27, 2024

Conversation

Vitalsine85
Copy link
Member

Affected Packages

Apps

  • data populator
  • portal
  • template

Packages

  • 1ui
  • api
  • graphql
  • protocol
  • sdk

Tools

  • tools

Overview

Overview of the changes in the PR.

Screen Captures

If applicable, add screenshots or screen captures of your changes.

Declaration

  • I hereby declare that I have abided by the rules and regulations as outlined in the CONTRIBUTING.md

@linear Linear
Copy link

linear bot commented Dec 26, 2024

ENG-5260 Add ARG to Dockerfile

@github-actions github-actions bot added the fix Fix label Dec 26, 2024
jonathanprozzi
jonathanprozzi approved these changes Dec 27, 2024
View reviewed changes
Copy link
Member

@jonathanprozzi jonathanprozzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, okay I think we've now covered all the bases with the updates.

@Vitalsine85 Vitalsine85 enabled auto-merge (squash) December 27, 2024 00:01
@Vitalsine85 Vitalsine85 merged commit 9d2bb12 into main Dec 27, 2024
3 checks passed
@Vitalsine85 Vitalsine85 deleted the vital/eng-5260-add-arg-to-dockerfile branch December 27, 2024 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathanprozzi jonathanprozzi jonathanprozzi approved these changes

Assignees
No one assigned
Labels
fix Fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Vitalsine85 @jonathanprozzi