Merge branch 'release/2.15.3'

HISTORY.md

@@ -1,3 +1,14 @@
+<a name="2.15.3"></a>
+## 2.15.3 (2019-04-30)
+
+
+### Bug Fixes
+
+- [#1198](https://github.com/RocketChat/Rocket.Chat.Electron/pull/1198) Add a module to handle deep links following the documentation
+- [#1196](https://github.com/RocketChat/Rocket.Chat.Electron/pull/1196) Safely compute initials for server name on sidebars
+
+
+
 <a name="2.15.2"></a>
 ## 2.15.2 (2019-04-16)
 

electron-builder.json

@@ -19,7 +19,7 @@
       "mas"
     ],
     "icon": "build/icon.icns",
-    "bundleVersion": "48",
+    "bundleVersion": "49",
     "helperBundleId": "chat.rocket.electron.helper",
     "type": "distribution",
 		"artifactName": "rocketchat-${version}.${ext}",

package.json

@@ -2,7 +2,7 @@
   "name": "rocketchat",
   "productName": "Rocket.Chat",
   "description": "Rocket.Chat Native Cross-Platform Desktop Application via Electron.",
-  "version": "2.15.2",
+  "version": "2.15.3",
   "author": "Rocket.Chat Support <[email protected]>",
   "copyright": "© 2019, Rocket.Chat",
   "homepage": "https://rocket.chat",

src/main.js

@@ -1,8 +1,7 @@
 import { app } from 'electron';
-import querystring from 'querystring';
-import url from 'url';
 import appData from './main/appData';
 import './main/basicAuth';
+import { processDeepLink } from './main/deepLinks';
 import './main/systemIdleTime';
 import './main/updates';
 import { getMainWindow } from './main/mainWindow';
@@ -17,21 +16,6 @@ export { default as notifications } from './main/notifications';
 export { default as certificate } from './main/certificateStore';
 
 
-function parseCommandLineArguments(args) {
-	args
-		.filter((arg) => /^rocketchat:\/\/./.test(arg))
-		.map((uri) => url.parse(uri))
-		.map(({ hostname, pathname, query }) => {
-			const { insecure } = querystring.parse(query);
-			return `${ insecure === 'true' ? 'http' : 'https' }://${ hostname }${ pathname || '' }`;
-		})
-		.slice(0, 1)
-		.forEach(async (serverUrl) => {
-			const mainWindow = await getMainWindow();
-			mainWindow.send('add-host', serverUrl);
-		});
-}
-
 function handleUncaughtException(error) {
 	console.error(error);
 	app.exit(1);
@@ -71,11 +55,11 @@ async function prepareApp() {
 
 	app.on('open-url', (event, url) => {
 		event.preventDefault();
-		parseCommandLineArguments([url]);
+		processDeepLink(url);
 	});
 
 	app.on('second-instance', (event, argv) => {
-		parseCommandLineArguments(argv.slice(2));
+		argv.slice(2).forEach(processDeepLink);
 	});
 }
 
@@ -85,5 +69,5 @@ async function prepareApp() {
 	await i18n.initialize();
 	app.emit('start');
 	await getMainWindow();
-	parseCommandLineArguments(process.argv.slice(2));
+	process.argv.slice(2).forEach(processDeepLink);
 })();

src/main/deepLinks.js

@@ -0,0 +1,44 @@
+import querystring from 'querystring';
+import url from 'url';
+import { getMainWindow } from './mainWindow';
+
+
+const normalizeUrl = (hostUrl) => {
+	if (!/^https?:\/\//.test(hostUrl)) {
+		return `https://${ hostUrl }`;
+	}
+
+	return hostUrl;
+};
+
+const processAuth = async ({ host, token, userId }) => {
+	const mainWindow = await getMainWindow();
+	const hostUrl = normalizeUrl(host);
+	mainWindow.send('add-host', hostUrl, { token, userId });
+};
+
+const processRoom = async ({ host, rid, path }) => {
+	const mainWindow = await getMainWindow();
+	const hostUrl = normalizeUrl(host);
+	mainWindow.send('add-host', hostUrl);
+	mainWindow.send('open-room', hostUrl, { rid, path });
+};
+
+export const processDeepLink = (link) => {
+	const { protocol, hostname:	action, query } = url.parse(link);
+
+	if (protocol !== 'rocketchat:') {
+		return;
+	}
+
+	switch (action) {
+		case 'auth': {
+			processAuth(querystring.parse(query));
+			break;
+		}
+		case 'room': {
+			processRoom(querystring.parse(query));
+			break;
+		}
+	}
+};

src/scripts/sidebar.js

@@ -91,7 +91,7 @@ class SideBar extends EventEmitter {
 				.replace(url, parseUrl(url).hostname)
 				.split(/[^A-Za-z0-9]+/g)
 				.slice(0, 2)
-				.map((text) => text[0].toUpperCase())
+				.map((text) => text.slice(0, 1).toUpperCase())
 				.join('')
 		);
 		const bustingParam = Math.round(Date.now() / faviconCacheBustingTime);