This repository was archived by the owner on Mar 12, 2023. It is now read-only.
Refactor REPL manager #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Monkey-patching Pry class directly to inject Jard's specific objects are bad. It may affect other plugins, prevent Jard and pry to co-exist, and make Jard hard to maintain forward compatibility in later verions of Pry. Creating a proxy class to isolate all Pry-related logic seems to be a good solution.
Pry::Commands aka Pry.config.commands is the registry that Pry uses to store declared commands. Jard implements a lot of custom commands. If it uses Pry::Commands, any binding.pry triggered later includes Jard's specific commands. That leads to a forever error loop.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
binding.pryandjardcan co-exist even after jard already starts. Related issue: [BUG] Control command is empty #70