Add SafeBase Module #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
0x0f0f0f
commented
Aug 27, 2024
0x0f0f0f
commented
- add safe base module
- Add SafeBase
- add more tests
|
@iamed2 would you have a moment to take a look at this? |
iamed2
reviewed
Aug 27, 2024
iamed2
reviewed
Aug 27, 2024
src/SafeBase.jl
Outdated
| This function can optionally throw if an exception is encountered. | ||
| Otherwise, a silent failure is indicated by returning `nothing`. | ||
| """ | ||
| function safe_eval(m::Module, expr)::Result{Any,EvalError} |
There was a problem hiding this comment.
What types can this accept? Why such a different implementation here?
iamed2
reviewed
Aug 27, 2024
iamed2
reviewed
Aug 27, 2024
|
I can look more this weekend, in the meantime can you make src/SafeBase.jl more BlueStyle? And add signatures to the new method docstrings that don't contain them. |
added 3 commits
September 2, 2024 14:47
|
@iamed2 addressed the comments. Thanks! |
|
Can I go ahead and merge? @iamed2 |
added 2 commits
November 15, 2024 13:02
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.