Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, broadcasting over e.g. a
Vector{<:Result}
complains aboutBase.length(::Result)
not defined, asResult
is assumed to be an iterator type. SinceResult
is not an iterator, I believe it would make sense to adaptBase.broadcastable
so that we can broadcast onResult
containers.I don't think this requires any tests, but I can add one if you prefer.
EDIT: my bad, broadcasting on a vector containing
Result
s is actually fine. The problem happens when broadcasting with aResult
notRef
ed. I still believe this to be nice to have, though.