Skip to content

Commit

Permalink
mm/sparsemem.c: defer the ms->section_mem_map clearing
Browse files Browse the repository at this point in the history
In sparse_init(), if CONFIG_SPARSEMEM_ALLOC_MEM_MAP_TOGETHER=y, system
will allocate one continuous memory chunk for mem maps on one node and
populate the relevant page tables to map memory section one by one.  If
fail to populate for a certain mem section, print warning and its
->section_mem_map will be cleared to cancel the marking of being present.
Like this, the number of mem sections marked as present could become less
during sparse_init() execution.

Here just defer the ms->section_mem_map clearing if failed to populate its
page tables until the last for_each_present_section_nr() loop.  This is in
preparation for later optimizing the mem map allocation.

Link: http://lkml.kernel.org/r/[email protected]
Signed-off-by: Baoquan He <[email protected]>
Acked-by: Dave Hansen <[email protected]>
Reviewed-by: Pavel Tatashin <[email protected]>
Reviewed-by: Oscar Salvador <[email protected]>
Cc: Kirill A. Shutemov <[email protected]>
Cc: Pankaj Gupta <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Stephen Rothwell <[email protected]>
  • Loading branch information
Baoquan He authored and sfrothwell committed Jul 22, 2018
1 parent 474e978 commit 269484b
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 5 deletions.
1 change: 0 additions & 1 deletion mm/sparse-vmemmap.c
Original file line number Diff line number Diff line change
Expand Up @@ -303,7 +303,6 @@ void __init sparse_mem_maps_populate_node(struct page **map_map,
ms = __nr_to_section(pnum);
pr_err("%s: sparsemem memory map backing failed some memory will not be available\n",
__func__);
ms->section_mem_map = 0;
}

if (vmemmap_buf_start) {
Expand Down
12 changes: 8 additions & 4 deletions mm/sparse.c
Original file line number Diff line number Diff line change
Expand Up @@ -446,7 +446,6 @@ void __init sparse_mem_maps_populate_node(struct page **map_map,
ms = __nr_to_section(pnum);
pr_err("%s: sparsemem memory map backing failed some memory will not be available\n",
__func__);
ms->section_mem_map = 0;
}
}
#endif /* !CONFIG_SPARSEMEM_VMEMMAP */
Expand Down Expand Up @@ -474,7 +473,6 @@ static struct page __init *sparse_early_mem_map_alloc(unsigned long pnum)

pr_err("%s: sparsemem memory map backing failed some memory will not be available\n",
__func__);
ms->section_mem_map = 0;
return NULL;
}
#endif
Expand Down Expand Up @@ -578,17 +576,23 @@ void __init sparse_init(void)
#endif

for_each_present_section_nr(0, pnum) {
struct mem_section *ms;
ms = __nr_to_section(pnum);
usemap = usemap_map[pnum];
if (!usemap)
if (!usemap) {
ms->section_mem_map = 0;
continue;
}

#ifdef CONFIG_SPARSEMEM_ALLOC_MEM_MAP_TOGETHER
map = map_map[pnum];
#else
map = sparse_early_mem_map_alloc(pnum);
#endif
if (!map)
if (!map) {
ms->section_mem_map = 0;
continue;
}

sparse_init_one_section(__nr_to_section(pnum), pnum, map,
usemap);
Expand Down

0 comments on commit 269484b

Please sign in to comment.