Skip to content

Commit

Permalink
feat: improved logging
Browse files Browse the repository at this point in the history
  • Loading branch information
01Joseph-Hwang10 committed May 10, 2024
1 parent 10ffff4 commit b43180a
Show file tree
Hide file tree
Showing 5 changed files with 24 additions and 10 deletions.
2 changes: 1 addition & 1 deletion ldm/api/installer/_installer.py
Original file line number Diff line number Diff line change
Expand Up @@ -87,4 +87,4 @@ def parse_dependency(

strategy.install(dependencies)

self.logger.info("Dependencies installed")
self.logger.success("Dependencies installed")
3 changes: 1 addition & 2 deletions ldm/api/installer/strategy/_parallel.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,8 @@ def install(self, dependencies):

def create_install_task(dependency: Dependency) -> None:
def install():
self.logger.debug(f"Installing {dependency.name}")
dependency.install()
self.logger.debug(f"Installed {dependency.name}")
self.logger.info(f"Installed {dependency.name}")

return install

Expand Down
1 change: 0 additions & 1 deletion ldm/api/installer/strategy/_sequential.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,5 @@ class SequentialInstallStrategy(InstallStrategy[SequentialConfig]):
def install(self, dependencies):
self.logger.debug("Installing dependencies sequentially")
for dependency in dependencies:
self.logger.info(f"Installing {dependency.name}")
dependency.install()
self.logger.info(f"Installed {dependency.name}")
26 changes: 21 additions & 5 deletions ldm/logger/_click_logger.py
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import sys
import click
from ._logger import Logger

Expand All @@ -8,31 +9,46 @@ def debug(self, message: str, *args, **kwargs) -> None:
return
kwargs.setdefault("fg", "blue")
message = f"[ldm] | DEBUG | {message}"
click.echo(click.style(message, *args, **kwargs))
click.echo(
click.style(message, *args, **kwargs),
file=sys.stdout,
)

def info(self, message: str, *args, **kwargs) -> None:
if self.level > 2:
return
message = f"[ldm] | INFO | {message}"
click.echo(click.style(message, *args, **kwargs))
click.echo(
click.style(message, *args, **kwargs),
file=sys.stdout,
)

def success(self, message: str, *args, **kwargs) -> None:
if self.level > 3:
return
message = f"[ldm] | SUCCESS | {message}"
kwargs.setdefault("fg", "green")
click.echo(click.style(message, *args, **kwargs))
click.echo(
click.style(message, *args, **kwargs),
file=sys.stdout,
)

def warning(self, message: str, *args, **kwargs) -> None:
if self.level > 4:
return
message = f"[ldm] | WARNING | {message}"
kwargs.setdefault("fg", "yellow")
click.echo(click.style(message, *args, **kwargs))
click.echo(
click.style(message, *args, **kwargs),
file=sys.stdout,
)

def error(self, message: str, *args, **kwargs) -> None:
if self.level > 5:
return
message = f"[ldm] | ERROR | {message}"
kwargs.setdefault("fg", "red")
click.echo(click.style(message, *args, **kwargs))
click.echo(
click.style(message, *args, **kwargs),
file=sys.stderr,
)
2 changes: 1 addition & 1 deletion tests/sequential/project/ldm.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,4 @@ dependencies:
-> src/styles/reset.css
config:
sequential:
sequential: {}

0 comments on commit b43180a

Please sign in to comment.