fix(super-tab): make sure we always have rootNavParams

fixes #126
zyra · Jan 25, 2018 · 192986d · 192986d
1 parent ca62985
commit 192986d
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 2 deletions.
diff --git a/src/components/super-tab.ts b/src/components/super-tab.ts
@@ -64,10 +64,21 @@ export class SuperTab extends NavControllerBase implements OnInit, AfterViewInit
    */
   @Input() root: any;
 
+  private _rootParams: any;
+  rootNavCtrl: NavControllerBase;
+
   /**
    * @input {object} Any nav-params to pass to the root page of this tab.
    */
-  @Input() rootParams: any;
+  @Input()
+  set rootParams(params: any) {
+    params.rootNavCtrl = this.rootNavCtrl;
+    this._rootParams = params;
+  }
+
+  get rootParams(): any {
+    return this._rootParams;
+  }
 
   @Input('id')
   tabId: string;

diff --git a/src/components/super-tabs.ts b/src/components/super-tabs.ts
@@ -445,8 +445,8 @@ export class SuperTabs implements OnInit, AfterContentInit, AfterViewInit, OnDes
   }
 
   addTab(tab: SuperTab) {
+    tab.rootNavCtrl = this.parent;
     tab.rootParams = tab.rootParams || {};
-    tab.rootParams.rootNavCtrl = this.parent;
 
     tab.tabId = tab.tabId || `super-tabs-${this.id}-tab-${this._tabs.length}`;