-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove historical migration scripts #3701
base: develop
Are you sure you want to change the base?
Conversation
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
@@ -20,8 +19,8 @@ func NewMigrator(keeper Keeper) Migrator { | |||
} | |||
|
|||
// Migrate1to2 migrates the authority store from consensus version 1 to 2 | |||
func (m Migrator) Migrate1to2(ctx sdk.Context) error { | |||
return v2.MigrateStore(ctx, m.authorityKeeper) | |||
func (m Migrator) Migrate1to2(_ sdk.Context) error { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these functions can be removed, but I see the older ones were still kept so I have followed the same pattern .
I will remove them if no one has any objections to it
Description
Closes : #3585
How Has This Been Tested?