Added support for breaking change in eslint v6+

[roniger]

No description provided.

[pladaria]

Please, accept this PR

[gabegorelick]

Better approach is to not rely on internal ESLint functions at all. See vuejs/eslint-plugin-vue#910 for comparison.

[roniger]

Agreed. Are you making the change?

…

On Fri, Sep 6, 2019 at 6:45 PM Gabe Gorelick ***@***.***> wrote: Better approach is to not rely on internal ESLint functions at all. See vuejs/eslint-plugin-vue#910 <vuejs/eslint-plugin-vue#910> for comparison. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#21?email_source=notifications&email_token=AAHKXF2ETWGQKXFV42YCGEDQIJ3JRA5CNFSM4H3FWDMKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6DH2QI#issuecomment-528907585>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAHKXF2XVVIALESO4GH3XUTQIJ3JRANCNFSM4H3FWDMA> .

[gabegorelick]

I would be happy to, but since there is no indication that any PR will get merged (none since 2017), I wasn't planning on it. See the (currently one-sided) discussion on #23.

[roniger]

Yes, it does look abandoned. I gave up on this initiative a while ago Doesn't seem like there will be any feedback any time soon

…

On Fri, Sep 6, 2019 at 8:59 PM Gabe Gorelick ***@***.***> wrote: I would be happy to, but since there is no indication that any PR will get merged (none since 2017), I wasn't planning on it. See the (currently one-sided) discussion on #23 <#23>. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#21?email_source=notifications&email_token=AAHKXF75IHK3NQVEDJNPA7LQIKK6BA5CNFSM4H3FWDMKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6DTEKI#issuecomment-528953897>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAHKXF57DJGPPSS5COM4JN3QIKK6BANCNFSM4H3FWDMA> .

[AdrieanKhisbe]

@roniger @gabegorelick

I considered at some point doing a published fork, but give up when realised that the plugin eslint-plugin-import does the job (and way more)

Here are the equivalent rules:

• dependencies/no-cycles -> import/no-cycle: doc
• dependencies/no-unresolved + dependencies/case-sensitive -> import/no-unresolved: doc
  • ⚠️ beware option is needed for require ({"commonjs": true})
  • for case sensitivity use the caseSensitive option
• dependencies/require-json-ext -> import/extensions: doc

Here is the list of all the rules: https://github.com/benmosher/eslint-plugin-import#rules

[AdrieanKhisbe]

☝️

that could interest you too @pladaria :)

and also everyone that 👍 the issues and comment
@despairblue, @Stegoo, @edi9999, @lynxtaa, @yelworc, @AdriVanHoudt, @mkamakura, @ErideDLF, @d2phap, @lynxtaa, @oknechirik

[gabegorelick]

import/no-cycle doesn't work for commonjs.

[mrtnzlml]

@AdrieanKhisbe We did exactly the same long time ago! 👍

[pladaria]

@AdrieanKhisbe sadly import/no-cycle doesn't work well with flowtype
import-js/eslint-plugin-import#1343
And looks like it has similar issues with typescript:
import-js/eslint-plugin-import#1453

We finally did an internal fork of this plugin

[dominicfraser]

@pladaria, would this fix your issue?

import-js/eslint-plugin-import#1494

[jeffreyc86]

@zertosh - Hi can you you please approve and merge this PR? theres a breaking change due to folder restructuring from eslint version updates

[zertosh]

Published as 2.5.0