Animation Gradient Button #2922
Conversation
|
🙏 Thanks for your pull request @Nsimmons91, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated! Some of the most popular are PR Statistics
|
🥳 Congratulations 🎉Congrats on making your first Pull Request in the Zero To Mastery Organization! ZTM Profile BadgeIf you'd like the ZTM Badge to show up on your profile, you will need to follow this guide! |
There was a problem hiding this comment.
Aloha @Nsimmons91 🙌
Thanks for your contribution !
Please address the given feedbacks - currently your PR is invalid as this does not meet the contribution goals .
For maintenance reasons, if the PRs do not have any activity this could have the status stale and then would be removed.
If you need any help, review the guideline our reach out to the discord :)
Have a good day !
There was a problem hiding this comment.
Incorrect animation
Please refer to the README.md
https://github.com/zero-to-mastery/Animation-Nation?tab=readme-ov-file#should-not
- this should not be a button as this requires an interaction whereas an animation is in constant movements
- this should be an animation ( ex: when using
@keyframescss )
|
🙏 Thanks for your pull request @Nsimmons91, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated! Some of the most popular are PR Statistics
|
|
🙏 Thanks for your pull request @Nsimmons91, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated! Some of the most popular are PR Statistics
|
1 similar comment
|
🙏 Thanks for your pull request @Nsimmons91, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated! Some of the most popular are PR Statistics
|
Thank you for making a pull request to ZTM's Animation Nation project. We will review your pull request as soon as we can, but keep in mind we can get very busy during Hacktoberfest.
While you're waiting, please look over this checklist. Feel free to write a description of what you did as well!
What I did
Added css styling to the button tag.
Created a gradient button feature.
Pull request checklist
meta.jsonfile.<github_username>-<art_name>without the <>.index.htmlandstyles.css.index.htmlstyles.cssmeta.jsonwith:githubHandle: being your unique github user name,artName: name of your animationNot normally needed
Note: if your pull request makes an improvement besides adding a CSS animation you will need to discuss this with the maintainers. You can help kickstart this process by explaining what your change does and why you are making it in the "What I did" section
What to expect