Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2111 - Fix class entry detection #2163

Merged
merged 6 commits into from
Mar 13, 2021
Merged

#2111 - Fix class entry detection #2163

merged 6 commits into from
Mar 13, 2021

Conversation

Jeckerson
Copy link
Member

@Jeckerson Jeckerson commented Mar 13, 2021 •
edited
Loading

Hello!

In raising this pull request, I confirm the following:

  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I updated the CHANGELOG

Small description of change:

Thanks

@Jeckerson Jeckerson added this to the 0.13.x milestone Mar 13, 2021
@Jeckerson Jeckerson self-assigned this Mar 13, 2021
@Jeckerson Jeckerson removed the request for review from sergeyklay March 13, 2021 19:03
@Jeckerson Jeckerson changed the base branch from development to zephir-php8 March 13, 2021 19:03
@codecov
Copy link

codecov bot commented Mar 13, 2021 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (zephir-php8@f1ec817). Click here to learn what that means.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             zephir-php8   #2163   +/-   ##
=============================================
  Coverage               ?   7.68%           
  Complexity             ?    8699           
=============================================
  Files                  ?     355           
  Lines                  ?   21993           
  Branches               ?       0           
=============================================
  Hits                   ?    1690           
  Misses                 ?   20303           
  Partials               ?       0

AlexNDRmac
AlexNDRmac approved these changes Mar 13, 2021
View reviewed changes
Library/ClassDefinition.php

return false;
$extendsClassDefinition = $this->getExtendsClassDefinition();
if ($extendsClassDefinition instanceof ClassDefinition && $extendsClassDefinition->hasProperty($name)) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

return $extendsClassDefinition instanceof ClassDefinition
&& $extendsClassDefinition->hasProperty($name);

@AlexNDRmac AlexNDRmac merged commit 990c298 into zephir-php8 Mar 13, 2021
@AlexNDRmac AlexNDRmac deleted the fix-class-entry-detection branch March 13, 2021 20:48
@Jeckerson Jeckerson modified the milestones: 0.13.x, 0.13.0 Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexNDRmac AlexNDRmac AlexNDRmac approved these changes

Assignees

@Jeckerson Jeckerson

Labels
None yet
Projects
None yet
Milestone
0.13.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Jeckerson @AlexNDRmac