Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

81 typo in settings #82

Merged
merged 5 commits into from
Jan 16, 2025
Merged

81 typo in settings #82

merged 5 commits into from
Jan 16, 2025

Conversation

MustafaJafar
Copy link
Contributor

@MustafaJafar MustafaJafar commented Jan 13, 2025

Changelog Description

resolve #81

This PR :

  1. Fix a typo in settings
  2. Cosmetics Update layout of lake_fs_overrides setting.

image

Testing notes:

The changes only affect setting title and layout so every thing should work as before.

@MustafaJafar MustafaJafar added the type: bug Something isn't working label Jan 13, 2025
@MustafaJafar MustafaJafar self-assigned this Jan 13, 2025
Copy link
Collaborator

@BigRoy BigRoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with me! Could you attach a screenshot showing the difference between the layout choices, making it easier to review by someone else whether it's better or not.

@MustafaJafar
Copy link
Contributor Author

Fine with me! Could you attach a screenshot showing the difference between the layout choices, making it easier to review by someone else whether it's better or not.

I've updated the PR description. Let me know if you have any further comments before merging.

@BigRoy BigRoy merged commit 49ed85c into develop Jan 16, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typo in settings
2 participants