Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix retime gathering from Nuke (freeze frame, linear speed and TimeWarp) #61

Merged
merged 4 commits into from
Feb 4, 2025
Merged

Fix retime gathering from Nuke (freeze frame, linear speed and TimeWarp) #61

merged 4 commits into from
Feb 4, 2025

Conversation

robin-ynput
Copy link
Contributor

@robin-ynput robin-ynput commented Jan 27, 2025 •
edited
Loading

Changelog Description

Resolve: ynput/ayon-hiero#12
Resolve: ynput/ayon-hiero#29

Adjusted:

  • Fix linear speed gathering and freeze frames
  • Ensure timewarps are properly retrieved

Additional notes

These changes needs to be tested alongside ynput/ayon-core#1109

Testing notes:

  1. Publish plates with speed-change (positive+negative), freeze frames and TimeWarp from an Editorial DCC
  2. Gather published plates in Nuke
  3. Ensure the working ranges match

@robin-ynput robin-ynput added the type: bug Something isn't working label Jan 27, 2025
@robin-ynput robin-ynput self-assigned this Jan 27, 2025
@robin-ynput robin-ynput added the sponsored This is directly sponsored by a client or community member label Jan 28, 2025
@robin-ynput robin-ynput marked this pull request as ready for review January 28, 2025 14:49
jakubjezek001
jakubjezek001 approved these changes Jan 29, 2025
View reviewed changes
Copy link
Member

@jakubjezek001 jakubjezek001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works perfectly

@robin-ynput
Copy link
Contributor Author

Waiting for official release of ynput/ayon-core#1087 to update requirements and merge.

@robin-ynput robin-ynput merged commit 24d1e41 into develop Feb 4, 2025
1 check passed
@robin-ynput robin-ynput deleted the bugfix/AY-5112_fix_retiming_gathering branch February 4, 2025 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iLLiCiTiT iLLiCiTiT iLLiCiTiT left review comments

@jakubjezek001 jakubjezek001 jakubjezek001 approved these changes

Assignees

@robin-ynput robin-ynput

Labels
sponsored This is directly sponsored by a client or community member type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bring back publishing of clip retimes AY-5112_Hiero: retimes publishing and vertical alignment problem
3 participants
@robin-ynput @jakubjezek001 @iLLiCiTiT