Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error missing arguments after addUserKnob #54

Merged
merged 1 commit into from
Jan 17, 2025
Merged

Fix error missing arguments after addUserKnob #54

merged 1 commit into from
Jan 17, 2025

Conversation

johhnry
Copy link

@johhnry johhnry commented Jan 17, 2025

Changelog Description

  • Replaces double quotes by single quotes in the add_button_clear_rendered function that adds Python code in a PyScript knob

Additional review information

The details are explained here: https://community.ynput.io/t/nuke-and-deadline-error-rendercompositingmain-missing-arguments-after-adduserknob/1957

Testing notes:

  1. Open Nuke
  2. Create a Render (write) publish instance
  3. Use Farm rendering
  4. Publish it and see the job on the farm, there shouldn't be any errors

Tagging @jakubjezek001

jakubjezek001
jakubjezek001 approved these changes Jan 17, 2025
View reviewed changes
Copy link
Member

@jakubjezek001 jakubjezek001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are awesome, thank you!

@jakubjezek001 jakubjezek001 merged commit 5fa975c into ynput:develop Jan 17, 2025
3 of 4 checks passed
@jakubjezek001 jakubjezek001 added the type: bug Something isn't working label Jan 17, 2025
@jakubjezek001 jakubjezek001 self-assigned this Jan 17, 2025
@johhnry johhnry deleted the adduserknob-fix branch January 17, 2025 15:36
@johhnry
Copy link
Author

johhnry commented Jan 17, 2025

Thanks! When will it get released?

@BigRoy
Copy link
Contributor

BigRoy commented Jan 21, 2025

Should be out since yesterday :)

@johhnry
Copy link
Author

johhnry commented Jan 21, 2025

@BigRoy Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakubjezek001 jakubjezek001 jakubjezek001 approved these changes

Assignees

@jakubjezek001 jakubjezek001

Labels
type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@johhnry @BigRoy @jakubjezek001