-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore containers with invalid UUID in representation #1
Ignore containers with invalid UUID in representation #1
Conversation
… and avoid issue when finding OpenPype invalid containers
Co-authored-by: Roy Nieterau <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good to me.
Initially I wasn't sure about the "private" ._asdict()
call to the namedtuple
that filter_containers
returns but I think there just isn't really a nicer way than that. So, fine with me.
Will leave the color choices and testing to someone else. :)
- Added loader category colors to constants file. - Updated lib file to use the new loader category colors constant.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fabiaserra I've committed the suggested changes to your fork - thanks for allowing open commits. It's been tested with older OpenPype containers and everything works well.
Regarding what you're seeing in Manager, it shouldn't be an issue as long as it lets you work with the screen.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't have nuke on my end but code looks good!
Awesome, thank you!! |
Description
When trying to save scenes that contain OpenPype UUIDs in representations Nuke was catching this error and not allowing you to save the scene:
This PR fixes it by reusing existing functions that already address this issue.
How to test