fix: additional workflow change #577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

asanehisa merged 1 commit into main from VULN-39622-yext-pages-run-shell-injection-in-github-workflows-generate-markdown-files-yml

Apr 3, 2025

Contributor

asanehisa commented Apr 3, 2025 •

edited

Loading

Required fix for vulnerability in addition to #573. Did not realize it was required because:

Semgrep updated their run-shell-injection rule a while back to treat {{steps. ... .outputs. ...}} — e.g. this file's outputs.pushed — as untrusted inputs that should be loaded in as Environment Variables through the env: option. Unfortunately, they did not update the description of their rule, so our ticket description was incomplete.


          additional workflow fix

65fad3d

asanehisa requested a review from a team as a code owner

April 3, 2025 20:21

asanehisa requested a review from mkilpatrick

April 3, 2025 20:21

mkilpatrick approved these changes

View reviewed changes

asanehisa merged commit 599690e into main

22 checks passed

asanehisa deleted the VULN-39622-yext-pages-run-shell-injection-in-github-workflows-generate-markdown-files-yml branch

April 3, 2025 20:24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet