Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

online.py - generation offset #27

Open
wwerkk opened this issue May 20, 2023 · 2 comments
Open

online.py - generation offset #27

wwerkk opened this issue May 20, 2023 · 2 comments
Labels
invalid This doesn't seem right

Comments

@wwerkk
Copy link
Owner

wwerkk commented May 20, 2023

The drumloop2 model generates rotations of the sequence which tend to move by token or two with each generation, even with temperature <=1.

Offline generation works properly, as it results in ABCB pattern which corresponds exactly to the drum pattern in the data.

Might be worth to test offline generation with longer sequences to determine if the pattern shifts in that case as well.

@wwerkk wwerkk added the invalid This doesn't seem right label May 20, 2023
@wwerkk
Copy link
Owner Author

wwerkk commented May 29, 2023

seems like even using the first maxlen tokens from original sequence on loop does not prevent the rotation - might be inherent to the way this model architecture predicts.
this problem could use some proper debugging for sure.

@wwerkk
Copy link
Owner Author

wwerkk commented May 29, 2023

generations in notebooks works flawlessly, which would suggest the issue is related generation loop in online.py specifically. some cross referencing between the generate function in the notebooks and in the script could potentially solve this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

1 participant