Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Byte-Pair Encoding #26

Open
wwerkk opened this issue May 20, 2023 · 2 comments
Open

Byte-Pair Encoding #26

wwerkk opened this issue May 20, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@wwerkk
Copy link
Owner

wwerkk commented May 20, 2023

It could help a lot to detect commonly occuring sub-sequences and replace them with a single token.

@wwerkk
Copy link
Owner Author

wwerkk commented May 20, 2023

could also help with #27

@wwerkk wwerkk added the enhancement New feature or request label May 20, 2023
@wwerkk
Copy link
Owner Author

wwerkk commented May 27, 2023

Test implementation using a toy dataset suggests it is an option, but two new problems come to mind:

  1. in picking from the most common sub-sequences that the used BPE implementation returns.
    This is fairly easy to solve by ensuring the replacement function starts doing so with the sub-sequence with highest number of occurrences, then goes to the second most common until there is no frames left that match any sub-sequence in the vocabulary.
  2. When tested with real world data, it would often be the case that there is no repeating label sub-sequences. This suggests a bigger problem within the pipeline, likely spread across all three stages of segmentation/analysis/classification and is unlikely to be resolved at this point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant