Skip to content

Commit

Permalink
Remove extra quote in trend
Browse files Browse the repository at this point in the history
Small code style fixes
  • Loading branch information
tobami committed Jan 20, 2011
1 parent 831dc08 commit b66f0c7
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 9 deletions.
24 changes: 16 additions & 8 deletions speedcenter/codespeed/views.py
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,8 @@ def getbaselineexecutables():
if hasattr(settings, 'def_baseline') and settings.def_baseline != None:
try:
for base in baseline:
if base['key'] == "none": continue
if base['key'] == "none":
continue
exename = settings.def_baseline['executable']
commitid = settings.def_baseline['revision']
if base['executable'].name == exename and base['revision'].commitid == commitid:
Expand Down Expand Up @@ -122,7 +123,8 @@ def getcomparisonexes():
return executables, executablekeys

def getcomparisondata(request):
if request.method != 'GET': return HttpResponseNotAllowed('GET')
if request.method != 'GET':
return HttpResponseNotAllowed('GET')
data = request.GET

executables, exekeys = getcomparisonexes()
Expand All @@ -149,12 +151,14 @@ def getcomparisondata(request):
return HttpResponse(json.dumps( compdata ))

def comparison(request):
if request.method != 'GET': return HttpResponseNotAllowed('GET')
if request.method != 'GET':
return HttpResponseNotAllowed('GET')
data = request.GET

# Configuration of default parameters
defaultenvironment = getdefaultenvironment()
if not defaultenvironment: return no_environment_error()
if not defaultenvironment:
return no_environment_error()
if 'env' in data:
try:
defaultenvironment = Environment.objects.get(name=data['env'])
Expand Down Expand Up @@ -185,7 +189,8 @@ def comparison(request):
checkedexecutables = []
if 'exe' in data:
for i in data['exe'].split(","):
if not i: continue
if not i:
continue
if i in exekeys:
checkedexecutables.append(i)
elif hasattr(settings, 'com_executables') and\
Expand Down Expand Up @@ -284,7 +289,8 @@ def comparison(request):
})

def gettimelinedata(request):
if request.method != 'GET': return HttpResponseNotAllowed('GET')
if request.method != 'GET':
return HttpResponseNotAllowed('GET')
data = request.GET

timeline_list = {'error': 'None', 'timelines': []}
Expand Down Expand Up @@ -374,12 +380,14 @@ def gettimelinedata(request):
return HttpResponse(json.dumps( timeline_list ))

def timeline(request):
if request.method != 'GET': return HttpResponseNotAllowed('GET')
if request.method != 'GET':
return HttpResponseNotAllowed('GET')
data = request.GET

# Configuration of default parameters
defaultenvironment = getdefaultenvironment()
if not defaultenvironment: return no_environment_error()
if not defaultenvironment:
return no_environment_error()
if 'env' in data:
try:
defaultenvironment = Environment.objects.get(name=data['env'])
Expand Down
2 changes: 1 addition & 1 deletion speedcenter/templates/codespeed/changes_table.html
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
{% if units.hasmin %}<th>Min</th>{% endif%}
{% if units.hasmax %}<th>Max</th>{% endif%}
<th title="Current change">Change</th>
<th title="Trend for the last {{ trendconfig }} revisions"">Trend</th>
<th title="Trend for the last {{ trendconfig }} revisions">Trend</th>
</tr>
</thead>
<tfoot>
Expand Down

0 comments on commit b66f0c7

Please sign in to comment.