Improve UX of role addition. #889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shilmyhasan
requested review from
lasanthaS,
Krishanx92,
tharikaGitHub and
piyumaldk
as code owners
|
piyumaldk
reviewed
Feb 18, 2025
| roleValidity: true, | ||
| validRoles: [...validRoles, validatedRole], | ||
| }); | ||
| } |
There was a problem hiding this comment.
Can we implement this code segment in a single place and reuse that in these 4 places? Possibly in Shared Component since these are different components?
There was a problem hiding this comment.
Lets fix this in another PR as this is an improvement @shilmyhasan Please note
AnuGayan
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the UX of role addition from secondary user store while creating/editing scopes. The fix programmatically converts the domain name in the role to upper case in order to be consistent with other instances in API Manger/