This repository has been archived by the owner on Oct 15, 2024. It is now read-only.
Add sample logic to users from a feature #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafaeldev
commented
Oct 12, 2019
| def get_users_sample(feature) | ||
| users = get_feature_sample(feature).users | ||
|
|
||
| return users unless users.empty? |
There was a problem hiding this comment.
If users sample was calculated before, return this list
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea of this PR is to supply a demand that emerged from this issue. => https://github.com/wirecardBrasil/jcurtain/issues/3
To resolve the idea of "get a sample for a given population of user" we create new keys for know:
feature:feature:users:session:percentage);feature:feature:users:session:sample);feature:feature:users:session:ttl_in_days);We used the namespace
sessionon keys to give idea which these lists will be removed in any some.Thanks for @eiguike for support