Attempts to resolve T213488 (compare commit 6fee058) #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## wikimedia #3 +/- ##
==========================================
Coverage 63.28% 63.28%
==========================================
Files 259 259
Lines 19722 19722
Branches 1968 1968
==========================================
Hits 12481 12481
Misses 7232 7232
Partials 9 9
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compare this pull request from the main Superset project.
Note the original patch seems to require Pandas version 0.23.1 (currently the requirement is 0.22) but it seems like Pandas 0.22.0 (which we currently run) already supports the necessary
pandas.rolling()interface, and in fact the current bug in T213488 is Pandas complaining about not having the deprecated interfaces, so they are apparently already gone in 0.22.0 anyway.So this patch ought to work as a drop-in, since the only code it's changing is code that is currently broken anyway.