Merge pull request apache#13 from ASUS-AICS/fix_Null_become_None_string

[Bug] Fix Null char becomes None
whelan9453 · May 28, 2020 · 53db46a · 53db46a
2 parents 58526cf + fc4b0a3
commit 53db46a
Showing 1 changed file with 9 additions and 4 deletions.
diff --git a/superset/views/core.py b/superset/views/core.py
@@ -2852,10 +2852,15 @@ def generate(header_has_type):
                     continue
 
                 for item in row:
-                    # Escape double quotes
-                    if '"' in str(item):
-                        item = item.replace('"', '""')
-                    s += f'"{item}",'
+                    # Avoid converting None to "None"
+                    if item == None:
+                        s += ','
+                    else:
+                        # Escape double quotes
+                        if '"' in str(item):
+                            item = item.replace('"', '""')
+                        s += f'"{item}",'
+                # Replace the latest "," with newline
                 s = s[:-1] + '\n'
                 yield s