Skip to content

Commit

Permalink
Added /healthcheck endpoint for integrations with envoy (apache#3819)
Browse files Browse the repository at this point in the history
* fixed mergeconflicts

* fixed mergeconflicts forreal this time

* added healthcheck test
  • Loading branch information
hughhhh authored and mistercrunch committed Nov 10, 2017
1 parent c8a34c6 commit fcd21d9
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 0 deletions.
3 changes: 3 additions & 0 deletions superset/views/core.py
Original file line number Diff line number Diff line change
Expand Up @@ -582,6 +582,9 @@ class LogModelView(SupersetModelView):
def health():
return "OK"

@app.route('/healthcheck')
def healthcheck():
return "OK"

@app.route('/ping')
def ping():
Expand Down
1 change: 1 addition & 0 deletions tests/core_tests.py
Original file line number Diff line number Diff line change
Expand Up @@ -271,6 +271,7 @@ def test_doctests(self):

def test_misc(self):
assert self.get_resp('/health') == "OK"
assert self.get_resp('/healthcheck') == "OK"
assert self.get_resp('/ping') == "OK"

def test_testconn(self, username='admin'):
Expand Down

0 comments on commit fcd21d9

Please sign in to comment.