Skip to content

Commit

Permalink
Unset 'series limit' default from 50 to null (apache#4410)
Browse files Browse the repository at this point in the history
Setting "Series Limit" by default results in a subquery (or 2 phase)
which can be suboptimal / unecessary where low cardinality dims
are used.
  • Loading branch information
mistercrunch authored Feb 13, 2018
1 parent c5b04e3 commit b477349
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions superset/assets/javascripts/explore/stores/controls.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -870,8 +870,11 @@ export const controls = {
label: t('Series limit'),
validators: [v.integer],
choices: formatSelectOptions(SERIES_LIMITS),
default: 50,
description: t('Limits the number of time series that get displayed'),
description: t(
'Limits the number of time series that get displayed. A sub query ' +
'(or an extra phase where sub queries are not supported) is applied to limit ' +
'the number of time series that get fetched and displayed. This feature is useful ' +
'when grouping by high cardinality dimension(s).'),
},

timeseries_limit_metric: {
Expand Down

0 comments on commit b477349

Please sign in to comment.