add authority for grpc channel #38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huan
reviewed
Nov 2, 2020
VERSION
Outdated
| @@ -1 +1 @@ | |||
| 0.2.16 | |||
| 0.2.17dev | |||
There was a problem hiding this comment.
You should not add any non-number to SemVers.
If you want to set the version for dev, you need to set the minor version to odd.
For example, set it to 0.3.1, then it will be the dev version when publishing to PyPI with our GitHub Actions DevOps script.
There was a problem hiding this comment.
I'am so careless that I ignore the SemVers rules. I have made it passed now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to #35 , we should add authority for grpc channel.