add proxy support to connect #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpinca
reviewed
Sep 20, 2019
bin/wscat
Outdated
| @@ -145,6 +146,9 @@ program | |||
| 'Enable slash commands for control frames ' + | |||
| '(/ping, /pong, /close [code [, reason]])' | |||
| ) | |||
| .option( | |||
| '--proxy <[protocol://]host[:port]>', | |||
| 'Use proxy on given port (--connect only).') | |||
There was a problem hiding this comment.
We should ideally specify that the proxy must be a HTTP/HTTPS proxy that support the CONNECT method.
There was a problem hiding this comment.
Added that to the comment flag info.
package.json
Outdated
| @@ -19,6 +19,7 @@ | |||
| "license": "MIT", | |||
| "dependencies": { | |||
| "commander": "~3.0.0", | |||
| "https-proxy-agent": "^2.2.2", | |||
There was a problem hiding this comment.
Unfortunately this does not work on Node.js >= 10.0.0, see TooTallNate/proxy-agents#73,
There was a problem hiding this comment.
Good catch. We might need to wait until that gets merged in?
Unless you can think of a workaround?
|
@enriquegh |
|
@lpinca updated the https-proxy-agent version and verified it works on 10.9.0 and 10.16.3 |
lpinca
approved these changes
Oct 11, 2019
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #54
Adds a new --proxy flag that will implement an https-proxy-agent and use the proxy specified.
Used this to test if my proxy could handle WebSocket connections and worked like a charm.
Thought I'd do a PR for this since there was some interest at some point.