Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a subscribeAll() method to the client to handle any events #112

Merged
merged 1 commit into from
Jun 28, 2016
Merged

Adds a subscribeAll() method to the client to handle any events #112

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions client.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,7 @@ function createReporter() {
var processUpdate = require('./process-update');

var customHandler;
var subscribeAllHandler;
function processMessage(obj) {
if (obj.action == "building") {
if (options.log) console.log("[HMR] bundle rebuilding");
Expand All @@ -144,10 +145,17 @@ function processMessage(obj) {
} else if (customHandler) {
customHandler(obj);
}

if (subscribeAllHandler) {
subscribeAllHandler(obj);
}
}

if (module) {
module.exports = {
subscribeAll: function subscribeAll(handler) {
subscribeAllHandler = handler;
},
subscribe: function subscribe(handler) {
customHandler = handler;
},
Expand Down
33 changes: 33 additions & 0 deletions test/client-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,36 @@ describe("client", function() {
}));
sinon.assert.calledOnce(processUpdate);
});
it("should call subscribeAll handler on default messages", function() {
var spy = sinon.spy();
client.subscribeAll(spy);
var message = {
action: 'built',
time: 100,
hash: 'deadbeeffeddad',
errors: [],
warnings: [],
modules: []
};

var eventSource = window.EventSource.lastCall.returnValue;
eventSource.onmessage(makeMessage(message));

sinon.assert.calledOnce(spy);
sinon.assert.calledWith(spy, message);
});
it("should call subscribeAll handler on custom messages", function() {
var spy = sinon.spy();
client.subscribeAll(spy);

var eventSource = window.EventSource.lastCall.returnValue;
eventSource.onmessage(makeMessage({
action: 'thingy'
}));

sinon.assert.calledOnce(spy);
sinon.assert.calledWith(spy, { action: 'thingy' });
});
it("should call only custom handler on custom messages", function() {
var spy = sinon.spy();
client.subscribe(spy);
Expand All @@ -47,6 +77,9 @@ describe("client", function() {
eventSource.onmessage(makeMessage({
custom: 'thingy'
}));
eventSource.onmessage(makeMessage({
action: 'built'
}));

sinon.assert.calledOnce(spy);
sinon.assert.calledWith(spy, { custom: 'thingy' });
Expand Down