fix: quiet flag only prints when set to false

[JaKXz]

No description provided.

[coveralls]

Coverage remained the same at 98.667% when pulling 4e47a5e on fix/quiet-strictly-false into e2f33b8 on master.

[coveralls]

Coverage remained the same at 98.667% when pulling 4e47a5e on fix/quiet-strictly-false into e2f33b8 on master.

[sergesemashko]

@JaKXz, here is the issue - #61

[sergesemashko]

Hey @JaKXz, I tested this locally.
It seems like this change has no effect, because quite is set to false by default here.
Wonder what is the reason of using quite here if webpack outputs warnings and errors to the console as well in onCompilation?
Maybe we could move it to onCompilation and have something like this:

compiler.plugin('after-emit', function onCompilation (compilation, callback) {
    if (warnings.length) {
      if (options.quiet === false) {
        compilation.warnings.push(chalk.yellow(options.formatter(warnings)));
      }
      warnings = [];
    }

    if (errors.length) {
      if (options.quiet === false) {
        compilation.errors.push(chalk.red(options.formatter(errors)));
      }
      errors = [];
    }

    callback();
  });

If at least something should be in the output, it can be:

if (warnings.length) {
  var formattedWarnings = chalk.yellow(options.formatter(warnings));
  if (options.quiet === false) {
    compilation.warnings.push(formattedWarnings);
  } else {
    console.log(formattedWarnings);
  }
  warnings = [];
}

what do you think?

[JaKXz]

I removed the default quiet value in this change though. I'll take a closer look at your suggestion later, but could you try installing this branch locally and I think it will solve the problem.

[coveralls]

Coverage increased (+0.02%) to 98.684% when pulling d0635bb on fix/quiet-strictly-false into e2f33b8 on master.

[coveralls]

Coverage increased (+0.02%) to 98.684% when pulling d0635bb on fix/quiet-strictly-false into e2f33b8 on master.

[JaKXz]

@sergesemashko I'm going to merge this for now so we can test stylelint-webpack-plugin#master.

[sergesemashko]

Looks good, duplicates are gone now