Use STORE as default method. #917
Conversation
|
Build succeeded. |
| @@ -168,7 +168,7 @@ core.Zip = function Zip(url, entriesReadCallback) { | |||
| */ | |||
| function createByteArray(successCallback, errorCallback) { | |||
| try { | |||
| successCallback(/**@type{!Uint8Array}*/(zip.generate({type: "uint8array", compression: "DEFLATE"}))); | |||
| successCallback(/**@type{!Uint8Array}*/(zip.generate({type: "uint8array", compression: "STORE"}))); | |||
There was a problem hiding this comment.
If I'm reading the JSZip API correctly, you theoretically don't need both of these specified. It appears that the generate compression is a fallback if no explicit level is set on the file. Does that match your understanding?
If that is the case, I'd be interested as to why or how the existing code was compressing the mimetype.
There was a problem hiding this comment.
I've added tests now that show the issue appears when saving from an exisiting odf file. In new odt files, the mimetype is not compressed.
vandenoever
force-pushed
the
mimetype
branch
2 times, most recently
from
6ff091e to
cf9b9e9
Compare
|
Build succeeded. |
This is important because the file "mimetype" should *never* be compressed.
vandenoever
force-pushed
the
mimetype
branch
from
cf9b9e9 to
7d30654
Compare
|
Build succeeded. |
|
Build succeeded. |
|
Ah... that makes more sense 😁 |
!!!Use STORE as default method.
This is important because the file "mimetype" should never be compressed.