Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrongly enabled hyperlink tools without a document loaded #833

Merged
merged 2 commits into from
Sep 24, 2014
Merged

Fix wrongly enabled hyperlink tools without a document loaded #833

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3053b18
Fix wrongly enabled hyperlink tools with no document loaded
Sep 24, 2014
a68442d
Remove duplicated code, linksInSelection is set later again
Sep 24, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions ChangeLog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,17 @@
# Changes between 0.5.4 and 0.5.5

## WebODF



## Wodo.TextEditor
See also section about WebODF

### Fixes

* Fix wrongly enabled hyperlink tools with no document loaded ([#833](https://github.com/kogmbh/WebODF/pull/833))


# Changes between 0.5.3 and 0.5.4

## WebODF
Expand Down
4 changes: 2 additions & 2 deletions programs/editor/widgets/editHyperlinks.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,11 +84,11 @@ define("webodf/editor/widgets/editHyperlinks", [

function updateHyperlinkButtons() {
var controllerEnabled = hyperlinkController && hyperlinkController.isEnabled(),
linksInSelection = controllerEnabled && editorSession.getSelectedHyperlinks();
linksInSelection;

// Enable to disable all widgets initially
widget.children.forEach(function (element) {
element.set('disabled', controllerEnabled === false, false);
element.set('disabled', controllerEnabled !== true, false);
});
if (controllerEnabled) {
// Specifically enable the remove hyperlink button only if there are links in the current selection
Expand Down