Update to Scope 0.13 #313
Update to Scope 0.13 #313
Conversation
2opremio
force-pushed
the
311-scope-0.13
branch
2 times, most recently
from
6e2e366 to
c0aacaf
Compare
|
You should run scope with the following arguments:
|
Both for: * The apps run in the service * The Scope instances used to monitor the service
|
I have successfully tested this in the local cluster
@tomwilkie PTAL |
|
@peterbourgon Maybe you can also have a look at the monitoring bits? There are new endpoints, some of which are websockets. |
|
Just one new websocket endpoint, right? And it looks like you're excluding it properly. 👍 |
|
@peterbourgon Good point, now that I think about it there's two .. one from the app. Let me exclude that one too. |
| args: | ||
| - --no-app | ||
| - --probe.docker.bridge=cbr0 | ||
| - --probe.docker=true | ||
| - --probe.kubernetes=true | ||
| - --app.weave.addr= |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
It turns out monitoring was broken too. I have fixed it in this PR as well since it requires updating monitoring due to an update in its rules. @tomwilkie @peterbourgon Please take a final look |
| @@ -98,13 +98,13 @@ func (f *flags) makeAppProvisioner() appProvisioner { | |||
|
|
|||
| var p appProvisioner | |||
|
|
|||
| args := []string{"--no-probe"} | |||
|
|
|||
| args := []string{"--no-probe", "--app.weave.addr="} | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
I had some questions but they were more for my own edification. LGTM. |
As part of #311
DO NOT MERGE YET, pipes don't work because of weaveworks/scope#1085 so we will need to make a new release (0.13.1) and update this PR accordingly.