Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix kubelet failure fallback and make port configurable #2309

Merged
merged 2 commits into from
Mar 8, 2017

Conversation

2opremio
Copy link
Contributor

@2opremio 2opremio commented Mar 7, 2017

Fixes #2258 (problem introduced by #2132 ) and adds a new flag to configure kubelet's port (--probe.kubernetes.kubelet-port)

@errordeveloper Can you please test this in Openshift in these two scenarios?

  1. Without setting the kubelet port appropriately (to make sure the fallback works)
  2. Setting the kubelet port appropriately

@2opremio 2opremio requested a review from errordeveloper March 7, 2017 13:32
@errordeveloper
Copy link
Contributor

  1. Without setting the kubelet port appropriately (to make sure the fallback works)

It works:

  1. Setting the kubelet port appropriately

As I've pointed out in #2258 (comment), I don't think changing port will help anything, but I can try.

@errordeveloper
Copy link
Contributor

So with --probe.kubernetes.kubelet-port=10250 it still takes the fallback code path and logs this:

<probe> WARN: 2017/03/08 17:40:02.163794 Cannot obtain local pods, reporting all (which may impact performance): Get http://localhost:10250/pods/: malformed HTTP response "\x15\x03\x01\x00\x02\x02"

@2opremio
Copy link
Contributor Author

2opremio commented Mar 8, 2017 via email

@2opremio 2opremio merged commit 052ff39 into master Mar 8, 2017
@2opremio 2opremio deleted the 2258-fix-kubelet-access branch March 8, 2017 18:15
@errordeveloper
Copy link
Contributor

Yeah, I said it is HTTPS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants