Fix type error on the Agents main view (#4233)

* Update CHANGELOG.md * Update kibana-vis.js Co-authored-by: Álex <[email protected]>
wazuh · Jun 13, 2022 · 7536c05 · 7536c05
1 parent dc60490
commit 7536c05
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,9 +4,9 @@ All notable changes to the Wazuh app project will be documented in this file.
 
 ## Wazuh v4.3.5 - Kibana 7.10.2, 7.16.x, 7.17.x - Revision 4306
 
-
 ### Fixed
 
+- Fixed type error when changing screen size in agents section [#4233](https://github.com/wazuh/wazuh-kibana-app/pull/4233)
 - Fixed an error when generating a module report after changing the selected agent [#4240](https://github.com/wazuh/wazuh-kibana-app/pull/4240)
 
 ### Changed

diff --git a/public/kibana-integrations/kibana-vis.js b/public/kibana-integrations/kibana-vis.js
@@ -109,7 +109,17 @@ class KibanaVis extends Component {
   componentWillUnmount() {
     if (this._isMounted) {
       this._isMounted = false;
-      this.updateVis();
+      // It would be good to continue investigating if it is
+      // necessary for the renderComplete() to be in the
+      // componentWillUnmount.
+      // In the renderComplete() the value of the $rootScope
+      // is changed, which affects the entire application.
+      // 
+      // Related issue:
+      // https://github.com/wazuh/wazuh-kibana-app/issues/4158
+      if (this.deadField) {
+        return this.renderComplete();
+      }
       this.destroyAll();
     }
   }