Skip to content

fix: only set readableObjectMode in recognize-stream if not present #907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 12, 2019
Merged

fix: only set readableObjectMode in recognize-stream if not present #907

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions lib/recognize-stream.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,12 +133,14 @@ class RecognizeStream extends Duplex {
constructor(options) {
// this stream only supports objectMode on the output side.
// It must receive binary data input.
super(options);
if (options.objectMode) {
options.readableObjectMode = true;
this.readableObjectMode = true;
delete options.objectMode;
}
super(options);
if (options.readableObjectMode && this.readableObjectMode === undefined) {
this.readableObjectMode = true;
}
this.options = options;
this.listening = false;
this.initialized = false;
Expand Down