Merge pull request image-rs#180 from image-rs/issue-image-1410-panic

Issue image 1410 panic
wartmanm · Jan 27, 2021 · a6efabe · a6efabe
2 parents b97ceaf + 59652e9
commit a6efabe
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 0 deletions.
diff --git a/src/decoder.rs b/src/decoder.rs
@@ -409,6 +409,10 @@ impl<R: Read> Decoder<R> {
             previous_marker = marker;
         }
 
+        if self.frame.is_none() {
+            return Err(Error::Format("end of image encountered before frame".to_owned()));
+        }
+
         let frame = self.frame.as_ref().unwrap();
 
         // If we're decoding a progressive jpeg and a component is unfinished, render what we've got

diff --git a/tests/crashtest/images/README.md b/tests/crashtest/images/README.md
@@ -7,3 +7,4 @@ derive-huffman-codes-overflow.jpg | Found by Pascal Hertleif (@killercup) while
 missing-sof.jpg           | Found by Corey Farwell (@frewsxcv) when fuzz testing
 extraneous-bytes-after-sos.jpg | Scan from brother DSmobile 920DW provided by Filip Lundborg (@filipl)
 missing-sos.jpg           | Generated in GIMP and manually edited by John Reynolds (@quilan1)
+missing-frame-image-1410.jpg | Found by @frewsxcv when fuzzing
diff --git a/tests/crashtest/images/missing-frame-image-1410.jpg b/tests/crashtest/images/missing-frame-image-1410.jpg