rollup 4.39.0 #1353
Merged
rollup 4.39.0 #1353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
packages/waku/src/lib/plugins/vite-plugin-rsc-entries.ts:48
- The conditional string concatenation using v.startsWith('./') within the template literal is somewhat unclear and could lead to unexpected outcomes. Consider refactoring this logic or adding a comment to clarify its intent and ensure consistent behavior.
` `case '${k}': return import(${v.startsWith('./') ? "'' + " : ''}'${v}');`
packages/waku/src/lib/builder/build.ts:233
- The mapping for SERVER_MODULE_MAP changes the generated path from a fixed "./${key}.js" to using the provided value from the map. Verify that this change is intentional and that the provided value is correct for all cases.
` val,`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1342
I feel like there's huge room for improvement in build.ts.