Skip to content

Review of Video 11: Applications in Smart Homes and Smart Cities #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

Tedoshiii
Copy link
Contributor

Copy link

netlify bot commented Apr 8, 2025

Deploy Preview for whatiswot canceled.

Name Link
🔨 Latest commit 680f4a1
🔍 Latest deploy log https://app.netlify.com/sites/whatiswot/deploys/680664ff88d9b80008383e39

Copy link
Member

@TallTed TallTed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upon acceptance. these should be propagated to the timestamped version.

@egekorkan
Copy link
Collaborator

@Tedoshiii other than one comment I did, the suggestions are good but you should commit them yourself in the video generation pipeline

@Tedoshiii
Copy link
Contributor Author

I've applied the new feedback and updated the video accordingly

@TallTed
Copy link
Member

TallTed commented Apr 10, 2025

@Tedoshiii — I'm sorry, I don't see where there is text to review or comment upon at https://murf.ai/share/lp1i25vc. Just looks like a video, to me.

@egekorkan
Copy link
Collaborator

@TallTed I have invited you with "Viewer" rights. With this, you can make comments to specific text (go to a block and a purple comment icon appears). I am not sure if this is an easier workflow to review as it doesn't have the GitHub suggestion feature. You will need to type everything yourself. The current way to provide feedback is also really good so it is upto you how you want to provide feedback. Thank you for taking the time, we really appreciate it!

@egekorkan
Copy link
Collaborator

To test the review via comments on Murf.ai, I did it there this time. There are two small comments but otherwise this is a nice video now. In the future, we should probably use github anyways since it shows community activity in a transparent manner

@egekorkan egekorkan requested a review from relu91 April 11, 2025 11:15
Copy link
Member

@relu91 relu91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I watched the video and I didn't spot any obvious problem. 👍🏻

@Tedoshiii
Copy link
Contributor Author

I've applied the feedback that was left via comments on Murf.ai

@egekorkan
Copy link
Collaborator

Reviewed during the call and it is very nice now. Merging after a small fix regarding activating vs actuating is pushed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants