Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed mailto: href issue #160 and links not being links #164

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

basdebruin
Copy link
Contributor

Fixed issue #160 where opening the preview screen more than once would repeatedly append the link to the href value.

Also fixed an issue where dynamic inputs (inputs with a 'add another' button) could not be links, specifically referring to the "Other evidence" section. It now auto-detects if it's a link and makes it an anchor element accordingly.

@nitedog
Copy link
Contributor

nitedog commented Sep 15, 2021

Thanks @basdebruin! Just to be sure, can you confirm that this PR should fix points 3 and 4 in the comments from Steve Green? Could you also take a quick look at PR #162, which should address points 1 and 2 from that same set of comments (just to make sure there are no conflicts or bugs). Thanks!

@basdebruin
Copy link
Contributor Author

Thanks @basdebruin! Just to be sure, can you confirm that this PR should fix points 3 and 4 in the comments from Steve Green? Could you also take a quick look at PR #162, which should address points 1 and 2 from that same set of comments (just to make sure there are no conflicts or bugs). Thanks!

That is correct, this PR should address points 3 and 4!
I checked PR #162 and found no conflicts (both make changes to generator_layout.html but not the same part of the file).
These PRs combined should fix all issues in Steve’s comment.

@nitedog
Copy link
Contributor

nitedog commented Sep 16, 2021

Thanks @basdebruin!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants