-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate the notes from the REC track documents #2694
Conversation
add redirects to old editor drafts; add acknowledgements to 3.4
remove broken function call from epub:type to aria role guide
only have rec track documents include the file
Note that we should probably shut off the workflows while making these changes as they're just going to fail trying to publish the redirect files. We could merge changes to all the paths in the yml files first, but that would trigger a publish and we don't really need new versions as it's only the editor draft locations that change (and the redirects will handle those). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One procedural step: we will have to ask for approval for the republication of the overview and the a11y note. These receiving new short names means it is a new note, new echidna secret token, etc.
We will have to discuss whether we want the history set up so that it jumps back to the epub 33 versions, actually. Probably it should, and that will require some extra magic on the header (we will cross the bridge when we get there).
My proposal is to do these steps (including a formal WG vote for the new votes) once the epub 34 line has been published. Just to avoid hopelessly messing up everything...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with separating the notes from the main specs.
Is it safe to merge this now and do those steps later? I've turned off all the workflows so any changes we make now will only be reflected in the editor drafts. |
Then I do not see why not. I think these steps are safe:
|
Most of the notes aren't directly tied to the major revisions, so rather than have to carry them forward each time this pull request splits them off into a new folder.
The changes in a nutshell are:
I noticed with the acknowledgements that we apply them inconsistently to notes. It seems like about half don't add acknowledgements and half do. For consistency, I've removed the include of the file from all the notes. If we keep acknowledgements in the notes then we have the same problem of needing to reference into a specific revisions list of participants. I don't think it's worth it. We could keep acknowledgements in the overview and a11y techniques, though, since those are tied to a revision. I'm open to going either way on those.
Why I moved /common to the root is similarly because if it's a version-specific folder then the notes get caught either having to be updated to reference into a revision folder or have to have their own copy.
Let me know if anyone has any issues with the above shuffling, or if there are other changes you think we could make.
If you want to review the new directory and file structure, it's probably going to be more readable by going through the branch itself: https://github.com/w3c/epub-specs/tree/move/notes
Preview | Diff