Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: refresh project dependencies #66

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

Conversation

AndreyYolkin
Copy link

In this PR we have:

  1. Cleaned up dependencies list
  2. Updated project and templates dependencies
  3. Adopted eslint v9 with flat config
  4. Migrated from discontinued vite-plugin-vue-layouts to vite-plugin-vue-layouts-next (see comment)

this also changes `module` to esnext. We are using esbuild to build, so between modern flags `nodenext` and `bundler` we should pick `bundler`
This also has a small refactoring of the package name prompt to handle modern requirements
Latest node allows to use --run flag to launch scripts faster
…youts-next

The main goal is to get latest version of deps installed. This also comes with migrating to vite-plugin-vue-layouts-next from discontinued vite-plugin-vue-layouts. Eslint integration was also updated
Copy link
Member

@johnleider johnleider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking really good. Only a few points of feedback.

@@ -1,6 +1,6 @@
import { build } from 'esbuild'

async function bundleMain () {
async function bundleMain() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to retain this space if there is an eslint option for it.

@@ -13,11 +16,18 @@ export default [
},

js.configs.recommended,
...pluginVue.configs['flat/recommended'],
...vue.configs['flat/recommended'],
...vuetify.configs['flat/base'],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't have to be part of this P.R., but would love to include vuetify eslint config here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a follow-up, the vuetify eslint plugin is really only for upgrading projects. It doesn't make much sense for new ones.

@@ -11,9 +11,13 @@
/>

<div class="text-center">
<div class="text-body-2 font-weight-light mb-n1">Welcome to</div>
<div class="text-body-2 font-weight-light mb-n1">
Welcome to
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we can allow these to be single line under certain circumstances, that would be preferred (part of the vuetify eslint config)

@@ -1,5 +1,8 @@
<template>
<v-footer height="40" app>
<v-footer
height="40"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here, a vuetify eslint config setting. I think it's 4 for the docs, we can mimic that.

@AndreyYolkin AndreyYolkin marked this pull request as draft March 26, 2025 22:41
@AndreyYolkin
Copy link
Author

AndreyYolkin commented Mar 26, 2025

Converting it to draft, I would like to merge #67 and use our refreshed eslint config first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants