-
-
Notifications
You must be signed in to change notification settings - Fork 8.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(vapor): vapor transition + transition-group #12962
Draft
edison1105
wants to merge
46
commits into
vapor
Choose a base branch
from
edison/feat/vaporTransition
base: vapor
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vapor-repl ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@vue/compiler-core
@vue/compiler-dom
@vue/compiler-ssr
@vue/compiler-vapor
@vue/compiler-sfc
@vue/reactivity
@vue/runtime-core
@vue/runtime-dom
@vue/runtime-vapor
@vue/server-renderer
@vue/shared
vue
@vue/compat
commit: |
47e4e13
to
71db1e0
Compare
71db1e0
to
41822e3
Compare
a6362cb
to
989e79f
Compare
989e79f
to
1e79054
Compare
93a4de3
to
f139002
Compare
f139002
to
841e0cf
Compare
841e0cf
to
11bcb21
Compare
1b5e9ef
to
27d15c5
Compare
27d15c5
to
3fcba1d
Compare
44be78b
to
afc732e
Compare
* wip: save * wip: save * wip: handle tag prop and attrs fallthrough * test: add e2e tests * [autofix.ci] apply automated fixes * wip: add more tests * [autofix.ci] apply automated fixes * wip: handle vdom interop * [autofix.ci] apply automated fixes * wip: vapor interop + filter out reserved props * [autofix.ci] apply automated fixes * fix: tests --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
b970e87
to
0e68999
Compare
0e68999
to
af2eb2d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compiler Changes
Transition
is automatically rewritten asVaporTransition
during compilationTransition
uses thev-if
, the compiler automatically adds a$key
property to the rendering result, making it easier for the runtime to track the element's leaving state using thekey
will be compiled to
Transition
has an explicitkey
, the compiler generates code that includescreateKeyedFragment
, which creates a newDynamicFragment
when thekey
changes, triggering transitionswill be compiled to
Runtime Changes
VaporTransition
component that reuses most of the logic fromruntime-dom/Transition
Transition
hooks are now stored on theblock.$transition
propertyDynamicFragment
Update Logic Modification:baseResolveTransitionHooks
from the existingresolveTransitionHooks
function to be shared betweenVaporTransition
andTransition
. Each component passes its own specificTransitionHooksContext
Transition
component now supports renderingVapor
components