Proxy work

manifests/init.pp

@@ -87,6 +87,13 @@
 # proxy_port = undef (default)
 #   If your environment requires a proxy host to download plugins it can be configured here
 #
+#
+# no_proxy_list = undef (default)
+#   List of hostname patterns to skip using the proxy.
+#   - Accepts input as array only.
+#   - Only effective if "proxy_host" and "proxy_port" are set.
+#
+#
 class jenkins(
   $version            = $jenkins::params::version,
   $lts                = $jenkins::params::lts,
@@ -100,6 +107,7 @@
   $install_java       = $jenkins::params::install_java,
   $proxy_host         = undef,
   $proxy_port         = undef,
+  $no_proxy_list      = undef,
   $cli                = undef,
   $libdir             = $jenkins::params::libdir,
 ) inherits jenkins::params {
@@ -111,6 +119,10 @@
     validate_bool($configure_firewall)
   }
 
+  if $no_proxy_list {
+    validate_array($no_proxy_list)
+  }
+
   anchor {'jenkins::begin':}
   anchor {'jenkins::end':}
 

manifests/proxy.pp

@@ -5,6 +5,11 @@
     fail("Use of private class ${name} by ${caller_module_name}")
   }
 
+  # Bring variables from Class['::jenkins'] into local scope.
+  $proxy_host = $::jenkins::proxy_host
+  $proxy_port = $::jenkins::proxy_port
+  $no_proxy_list = $::jenkins::no_proxy_list
+
   file { '/var/lib/jenkins/proxy.xml':
     content => template('jenkins/proxy.xml.erb'),
     owner   => 'jenkins',

spec/classes/jenkins_proxy_spec.rb

@@ -8,12 +8,22 @@
       it { should_not contain_class('jenkins::proxy') }
     end
 
-    context 'with proxy config' do
+    context 'with basic proxy config' do
       let(:params) { { :proxy_host => 'myhost', :proxy_port => 1234 } }
       it { should create_class('jenkins::proxy') }
       it { should contain_file('/var/lib/jenkins/proxy.xml') }
       it { should contain_file('/var/lib/jenkins/proxy.xml').with(:content => /<name>myhost<\/name>/) }
       it { should contain_file('/var/lib/jenkins/proxy.xml').with(:content => /<port>1234<\/port>/) }
+      it { should contain_file('/var/lib/jenkins/proxy.xml').without(:content => /<noProxyHost>/) }
+    end
+
+    context 'with "no_proxy_list" proxy config' do
+      let(:params) { { :proxy_host => 'myhost', :proxy_port => 1234, :no_proxy_list => ['example.com','test.host.net'] } }
+      it { should create_class('jenkins::proxy') }
+      it { should contain_file('/var/lib/jenkins/proxy.xml') }
+      it { should contain_file('/var/lib/jenkins/proxy.xml').with(:content => /<name>myhost<\/name>/) }
+      it { should contain_file('/var/lib/jenkins/proxy.xml').with(:content => /<port>1234<\/port>/) }
+      it { should contain_file('/var/lib/jenkins/proxy.xml').with(:content => /<noProxyHost>example\.com\ntest\.host\.net<\/noProxyHost>/) }
     end
   end
 

templates/proxy.xml.erb

@@ -1,4 +1,7 @@
 <proxy>
-  <name><%= scope.lookupvar('::jenkins::proxy_host') %></name>
-  <port><%= scope.lookupvar('::jenkins::proxy_port') %></port>
+  <name><%= @proxy_host %></name>
+  <port><%= @proxy_port %></port>
+<% if @no_proxy_list -%>
+  <noProxyHost><%= @no_proxy_list.join("\n") %></noProxyHost>
+<% end -%>
 </proxy>